r12509 | thestig@chromium.org | 2009-03-25 15:43:37 -0700 (Wed, 25 Mar 2009) | 4 lines
Add an exception to DownloadManager::GenerateExtension() for .tar.gz files with mime_type "application/x-tar".
BUG=5772
Review URL: http://codereview.chromium.org/42622
------------------------------------------------------------------------
r12467 | thestig@chromium.org | 2009-03-25 11:02:27 -0700 (Wed, 25 Mar 2009) | 6 lines
Do not apply gzip filter to file names with gz/tgz/svgz extensions.
This matches Firefox's behavior.
BUG=8170
Review URL: http://codereview.chromium.org/42452
------------------------------------------------------------------------
r12425 | thestig@chromium.org | 2009-03-24 17:40:27 -0700 (Tue, 24 Mar 2009) | 4 lines
Propagate CC, CXX variables to Webcore and v8.
I realize this will all go away Any Day Now. Until then, we can speed things up a bit more.
Review URL: http://codereview.chromium.org/53029
------------------------------------------------------------------------
r12410 | thestig@chromium.org | 2009-03-24 16:38:01 -0700 (Tue, 24 Mar 2009) | 8 lines
Prevent data read errors from crashing the browser.
In ResourceDispatcherHost::OnResponseStarted(), if Read() causes an error, it calls OnResponseCompleted(). For a download, this hits the NOTREACHED() in DownloadThrottlingResourceHandler::OnResponseCompleted().
This patch checks for the error status, and returns false, which causes the download to finish, which saves an empty file of size 0.
BUG=8170
Review URL: http://codereview.chromium.org/42573
------------------------------------------------------------------------
r11986 | thestig@chromium.org | 2009-03-18 10:46:52 -0700 (Wed, 18 Mar 2009) | 2 lines
Let checkdeps ignore #if 0 blocks. Also strip lines of leading/trailing whitespaces before checking.
Review URL: http://codereview.chromium.org/42316
------------------------------------------------------------------------
r11974 | thestig@chromium.org | 2009-03-18 10:19:50 -0700 (Wed, 18 Mar 2009) | 2 lines
Remove unneeded uses of base/ref_counted.h.
Review URL: http://codereview.chromium.org/48105
------------------------------------------------------------------------
r11928 | thestig@chromium.org | 2009-03-17 16:03:57 -0700 (Tue, 17 Mar 2009) | 2 lines
Remove unneeded uses of base/hash_tables.h.
Review URL: http://codereview.chromium.org/48098
------------------------------------------------------------------------
r11787 | thestig@chromium.org | 2009-03-16 15:32:06 -0700 (Mon, 16 Mar 2009) | 2 lines
Clean up some more DEPS in chrome/common.
Review URL: http://codereview.chromium.org/48024
------------------------------------------------------------------------
r11766 | thestig@chromium.org | 2009-03-16 13:02:42 -0700 (Mon, 16 Mar 2009) | 2 lines
Removed unneeded includes of base/time.h.
Review URL: http://codereview.chromium.org/48019
------------------------------------------------------------------------
r11680 | thestig@chromium.org | 2009-03-13 16:12:09 -0700 (Fri, 13 Mar 2009) | 2 lines
Remove unneeded includes of gtest_prod.h. Reduce usage from 689 to 601.
Review URL: http://codereview.chromium.org/42189
------------------------------------------------------------------------
r11651 | thestig@chromium.org | 2009-03-13 12:11:59 -0700 (Fri, 13 Mar 2009) | 2 lines
Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files to ~400.
Review URL: http://codereview.chromium.org/46039
------------------------------------------------------------------------
r11619 | thestig@chromium.org | 2009-03-12 21:35:37 -0700 (Thu, 12 Mar 2009) | 4 lines
Allow PRESUBMIT.py to handle deleted files.
This is a follow up to Issue 43098.
Review URL: http://codereview.chromium.org/42086
------------------------------------------------------------------------
r11617 | thestig@chromium.org | 2009-03-12 21:27:33 -0700 (Thu, 12 Mar 2009) | 2 lines
Remove unneeded platform_thread.h includes. Reduces number of includes from 598 to 511.
Review URL: http://codereview.chromium.org/42165
------------------------------------------------------------------------
r11593 | thestig@chromium.org | 2009-03-12 16:20:46 -0700 (Thu, 12 Mar 2009) | 2 lines
Remove logging.h from cc files that don't use it.
Review URL: http://codereview.chromium.org/42155
------------------------------------------------------------------------
r11590 | thestig@chromium.org | 2009-03-12 15:41:54 -0700 (Thu, 12 Mar 2009) | 2 lines
Remove unneeded uses of logging.h in header files.
Review URL: http://codereview.chromium.org/43148
------------------------------------------------------------------------
r11502 | thestig@chromium.org | 2009-03-11 17:23:07 -0700 (Wed, 11 Mar 2009) | 2 lines
Remove unneeded includes of googleurl/src/url_parse.h and url_canon.h.
Review URL: http://codereview.chromium.org/42102
------------------------------------------------------------------------
r11412 | thestig@chromium.org | 2009-03-10 18:24:32 -0700 (Tue, 10 Mar 2009) | 5 lines
Install more signal handlers so test shell cleanup after itself.
Found a couple more cases where we are littering files in /tmp. a) if we run test_shell and hit ctrl+c, b) if the test shell gets killed by KillAllTestShells().
Review URL: http://codereview.chromium.org/45003
------------------------------------------------------------------------
r11354 | thestig@chromium.org | 2009-03-10 12:08:12 -0700 (Tue, 10 Mar 2009) | 4 lines
Attempt to cleanup after ourselves on test shell timeout.
The Linux buildbots have thousands of com.google.chrome.xxxxxx files in /tmp. We get one with every layout test time out.
Review URL: http://codereview.chromium.org/43030
------------------------------------------------------------------------
r11352 | darin@chromium.org | 2009-03-10 11:56:49 -0700 (Tue, 10 Mar 2009) | 1 line
add glue.vcproj
------------------------------------------------------------------------
r11349 | thestig@chromium.org | 2009-03-10 11:20:44 -0700 (Tue, 10 Mar 2009) | 2 lines
Move FilePathTest under test_dir_ so it gets cleaned up on TearDown.
Review URL: http://codereview.chromium.org/41023
------------------------------------------------------------------------
r11194 | thestig@chromium.org | 2009-03-06 18:56:24 -0800 (Fri, 06 Mar 2009) | 2 lines
Remove redundent expected layout test results. These are the same as the ones under chromium-win.
Review URL: http://codereview.chromium.org/40262
------------------------------------------------------------------------
r11192 | thestig@chromium.org | 2009-03-06 18:48:50 -0800 (Fri, 06 Mar 2009) | 2 lines
Rebaseline text/text-text-0[5-7]-t tests on Linux. The images only differ in the highlight color from before, and the text files now match the other platforms.
Review URL: http://codereview.chromium.org/40261
------------------------------------------------------------------------
r11163 | thestig@chromium.org | 2009-03-06 13:55:46 -0800 (Fri, 06 Mar 2009) | 2 lines
Rebase cg-fallback-bolding test on Linux. We have anti-aliasing turned on.
Review URL: http://codereview.chromium.org/40247
------------------------------------------------------------------------
r11144 | thestig@chromium.org | 2009-03-06 11:59:51 -0800 (Fri, 06 Mar 2009) | 4 lines
Rebaseline text-overflow-ellipsis test on Linux.
The fonts are slightly different under Linux as well. (see issue 21189)
Review URL: http://codereview.chromium.org/40191
------------------------------------------------------------------------
r10948 | thestig@chromium.org | 2009-03-04 17:14:22 -0800 (Wed, 04 Mar 2009) | 4 lines
Let the server accept multiple trybots.
We currently send the list of trybots as comma separated text, but we don't parse it correctly on the server.
Review URL: http://codereview.chromium.org/39167
------------------------------------------------------------------------
r10761 | thestig@chromium.org | 2009-03-02 16:41:23 -0800 (Mon, 02 Mar 2009) | 2 lines
Move chrome/apps/result_codes.h to chrome/common/result_codes.h
Review URL: http://codereview.chromium.org/28279
------------------------------------------------------------------------
r10740 | thestig@chromium.org | 2009-03-02 14:40:58 -0800 (Mon, 02 Mar 2009) | 2 lines
Convert encryptor.cc and friends to string16.
Review URL: http://codereview.chromium.org/28292
------------------------------------------------------------------------
r10588 | thestig@chromium.org | 2009-02-26 21:06:12 -0800 (Thu, 26 Feb 2009) | 2 lines
Use unix path separators in checkdeps. Otherwise it doesn't work on Unix systems.
Review URL: http://codereview.chromium.org/27253
------------------------------------------------------------------------
r10580 | thestig@chromium.org | 2009-02-26 20:07:04 -0800 (Thu, 26 Feb 2009) | 2 lines
Use xdg_user_dir_lookup to lookup directories. (try 2)
Review URL: http://codereview.chromium.org/27259
------------------------------------------------------------------------
r10560 | thestig@chromium.org | 2009-02-26 17:24:16 -0800 (Thu, 26 Feb 2009) | 2 lines
Reverting 10555.
Review URL: http://codereview.chromium.org/28239
------------------------------------------------------------------------
r10555 | thestig@chromium.org | 2009-02-26 17:04:53 -0800 (Thu, 26 Feb 2009) | 3 lines
Use xdg_user_dir_lookup to lookup directories.
Reviewed in issue 27186.
------------------------------------------------------------------------
r10554 | evan@chromium.org | 2009-02-26 17:04:47 -0800 (Thu, 26 Feb 2009) | 1 line
RLZ NOTIMPLEMENTEDs -> bug.
------------------------------------------------------------------------
r10553 | thestig@chromium.org | 2009-02-26 17:03:54 -0800 (Thu, 26 Feb 2009) | 2 lines
Add xdg-user-dirs to chrome/third_party.
Review URL: http://codereview.chromium.org/27186
------------------------------------------------------------------------
r9934 | thestig@chromium.org | 2009-02-17 19:16:18 -0800 (Tue, 17 Feb 2009) | 2 lines
Get something in chrome/plugin/ compiling to make Scons happy.
Review URL: http://codereview.chromium.org/20449
------------------------------------------------------------------------
r9927 | thestig@chromium.org | 2009-02-17 16:59:15 -0800 (Tue, 17 Feb 2009) | 2 lines
Don't use relative path for net/url_request/url_request_test_job.
Review URL: http://codereview.chromium.org/20443
------------------------------------------------------------------------
r9921 | thestig@chromium.org | 2009-02-17 16:08:05 -0800 (Tue, 17 Feb 2009) | 2 lines
Add more scaffolding to make shared linking work.
Review URL: http://codereview.chromium.org/21429
------------------------------------------------------------------------
r9914 | thestig@chromium.org | 2009-02-17 14:56:03 -0800 (Tue, 17 Feb 2009) | 2 lines
Add importer/firefox_profile_lock_posix.cc to the build.
Review URL: http://codereview.chromium.org/21427
------------------------------------------------------------------------
r9815 | thestig@chromium.org | 2009-02-13 17:40:25 -0800 (Fri, 13 Feb 2009) | 2 lines
Add additional library dependencies for the shared linking of ipc_tests.
Review URL: http://codereview.chromium.org/21367
------------------------------------------------------------------------
r9814 | thestig@chromium.org | 2009-02-13 17:40:11 -0800 (Fri, 13 Feb 2009) | 2 lines
Add a couple more stubs to file_version_info_linux.cc.
Review URL: http://codereview.chromium.org/21366
------------------------------------------------------------------------
r9776 | thestig@chromium.org | 2009-02-13 11:25:45 -0800 (Fri, 13 Feb 2009) | 4 lines
Add debugger_shell to the POSIX build.
Reviewed in issue 20321. Got reverted, but was not the cause of the debugger test failure.
Review URL: http://codereview.chromium.org/21355
------------------------------------------------------------------------
r9775 | thestig@chromium.org | 2009-02-13 11:25:32 -0800 (Fri, 13 Feb 2009) | 2 lines
Fix duplicate entries in third_party scons files.
Review URL: http://codereview.chromium.org/20365
------------------------------------------------------------------------
r9730 | thestig@chromium.org | 2009-02-12 17:52:48 -0800 (Thu, 12 Feb 2009) | 2 lines
Add TableModel to the scaffold, so we don't depend on views.
Review URL: http://codereview.chromium.org/21315
------------------------------------------------------------------------
r9717 | thestig@chromium.org | 2009-02-12 16:49:00 -0800 (Thu, 12 Feb 2009) | 2 lines
Reverting 9706. Hopefully this will fix the broken debugger_test.
Review URL: http://codereview.chromium.org/21329
------------------------------------------------------------------------
r9707 | thestig@chromium.org | 2009-02-12 13:11:13 -0800 (Thu, 12 Feb 2009) | 4 lines
Remove firefox[23]_importer.cc from the POSIX build.
Another step in fixing the dynamic run.
Review URL: http://codereview.chromium.org/20323
------------------------------------------------------------------------
r9706 | thestig@chromium.org | 2009-02-12 13:11:05 -0800 (Thu, 12 Feb 2009) | 4 lines
Add debugger_shell to the POSIX build.
Fixes static linking for the chrome executable on Linux.
Review URL: http://codereview.chromium.org/20321
------------------------------------------------------------------------
r9647 | thestig@chromium.org | 2009-02-11 20:53:51 -0800 (Wed, 11 Feb 2009) | 2 lines
Make fav_icon_helper compile on POSIX, remove some unneeded #includes.
Review URL: http://codereview.chromium.org/20286
------------------------------------------------------------------------
r9646 | thestig@chromium.org | 2009-02-11 20:53:03 -0800 (Wed, 11 Feb 2009) | 2 lines
Fix Linux shared build breakage in v8 bindings from r9568.
Review URL: http://codereview.chromium.org/21282
------------------------------------------------------------------------
r9624 | thestig@chromium.org | 2009-02-11 15:59:25 -0800 (Wed, 11 Feb 2009) | 2 lines
janitorial: browser_render_process_host header/lint cleanup. (try 2)
Review URL: http://codereview.chromium.org/21272
------------------------------------------------------------------------
r9599 | thestig@chromium.org | 2009-02-11 13:40:40 -0800 (Wed, 11 Feb 2009) | 2 lines
Reverting 9594.
Review URL: http://codereview.chromium.org/20276
------------------------------------------------------------------------
r9594 | thestig@chromium.org | 2009-02-11 13:23:55 -0800 (Wed, 11 Feb 2009) | 2 lines
janitorial: clean up unnecessary includes in src/chrome/renderer.
Review URL: http://codereview.chromium.org/20266
------------------------------------------------------------------------
r9332 | thestig@chromium.org | 2009-02-06 12:19:05 -0800 (Fri, 06 Feb 2009) | 2 lines
Janitorial: browser_render_process_host header/lint cleanup. Remove lots of header files it doesn't need and add the ones it does use.
Review URL: http://codereview.chromium.org/21135
------------------------------------------------------------------------
r9289 | thestig@chromium.org | 2009-02-05 16:16:37 -0800 (Thu, 05 Feb 2009) | 2 lines
Cleanup forward declared classes that are not needed in chrome/renderer, chrome/test/, and chrome/views. Also fix some lint issues while I'm at it.
Review URL: http://codereview.chromium.org/20112
------------------------------------------------------------------------
r9288 | thestig@chromium.org | 2009-02-05 16:15:51 -0800 (Thu, 05 Feb 2009) | 2 lines
Make render_widget_host_unittest compile and run on POSIX.
Review URL: http://codereview.chromium.org/20115
------------------------------------------------------------------------
r9269 | thestig@chromium.org | 2009-02-05 14:47:10 -0800 (Thu, 05 Feb 2009) | 4 lines
Cleanup some forward declared structs that are not being used.
Also do some lint removal while I'm at it.
Review URL: http://codereview.chromium.org/20107
------------------------------------------------------------------------
r9200 | thestig@chromium.org | 2009-02-04 17:03:56 -0800 (Wed, 04 Feb 2009) | 2 lines
Make mock_render_process_host, test_web_contents, and testing_profile compile on POSIX.
Review URL: http://codereview.chromium.org/23005
------------------------------------------------------------------------
r9176 | thestig@chromium.org | 2009-02-04 14:07:54 -0800 (Wed, 04 Feb 2009) | 2 lines
Make autofill_manager compile on POSIX.
Review URL: http://codereview.chromium.org/22002
------------------------------------------------------------------------
r9157 | thestig@chromium.org | 2009-02-04 11:22:40 -0800 (Wed, 04 Feb 2009) | 4 lines
Make render_view_host_manager.cc compile on POSIX.
Get rid of forward-declared enums in render_view_host.h and unneeded headers in render_view_host_manager.h.
Review URL: http://codereview.chromium.org/21048
------------------------------------------------------------------------
r9065 | thestig@chromium.org | 2009-02-02 18:11:48 -0800 (Mon, 02 Feb 2009) | 10 lines
From agl. Cleaned up version of issue 19046.
POSIX: bitmap data on the wire
On Windows, when drawing a given rect in the renderer, we allocate memory for the bitmap, render and send a shared memory handle across IPC. In the browser, we bitblit the shared memory to the backing store and draw it to the screen.
In the long term, on Linux, we want the backingstore to be shared with both X and the renderer. The renderer then draws directly to that store, sends an IPC to the browser and the browser sends a message to X to bitblit to the display. Since only cache a few backing stores we'll need messages from the browser to tell the renderer to attach and detatch from shared memory regions as they get created and evicted.
In the short term, however, to get something that works, we make a BitmapWireData typedef. This will be a shared memory region on Windows, as before, and on POSIX we'll be sending the bitmap data over the wire. Obviously this'll be pretty slow but it'll work sooner.
Review URL: http://codereview.chromium.org/19491
------------------------------------------------------------------------
r8933 | thestig@chromium.org | 2009-01-29 16:34:11 -0800 (Thu, 29 Jan 2009) | 2 lines
Fix a bunch of lint complaints in preparation to land issue 19046. Mostly formatting changes, i.e. CRLF, space at end of line.
Review URL: http://codereview.chromium.org/19486
------------------------------------------------------------------------
r8853 | thestig@chromium.org | 2009-01-28 17:52:36 -0800 (Wed, 28 Jan 2009) | 2 lines
Update tests_fixable with results from build 1426 (r8834)
Review URL: http://codereview.chromium.org/19647
------------------------------------------------------------------------
r8842 | thestig@chromium.org | 2009-01-28 16:15:41 -0800 (Wed, 28 Jan 2009) | 4 lines
Add media/base to the build.
r8805 made it compile.
Review URL: http://codereview.chromium.org/19422
------------------------------------------------------------------------
r8798 | thestig@chromium.org | 2009-01-27 23:14:01 -0800 (Tue, 27 Jan 2009) | 5 lines
Add sqlite to list of things to build.
Follow up to issue 19041/r8767. Building with SHARED=1 --mode=opt got errors with missing sqlite. Move sqlite append from chrome/SConscript to build/SConscript.main.
Review URL: http://codereview.chromium.org/19615
------------------------------------------------------------------------
r8675 | thestig@chromium.org | 2009-01-26 15:23:39 -0800 (Mon, 26 Jan 2009) | 4 lines
Add missing instruction_map.cc in sdch/SConscript.
This fixes the SHARED=1 build on Linux. sdch/SConscript last changed in r8644/issue 18717.
Review URL: http://codereview.chromium.org/18816
------------------------------------------------------------------------
r8649 | thestig@chromium.org | 2009-01-26 11:15:54 -0800 (Mon, 26 Jan 2009) | 5 lines
Do no use custom gtkrc files in layout test mode.
On desktop environments like KDE, custom gtkrc files prevent test shell from
setting the theme correctly.
Review URL: http://codereview.chromium.org/18769
------------------------------------------------------------------------
r8519 | thestig@chromium.org | 2009-01-22 15:27:15 -0800 (Thu, 22 Jan 2009) | 13 lines
Rebaseline tests where sizes are off by 1 due to font differences.
For fast/forms/input-baseline.html, RenderTextControl::calcHeight() uses the
value from m_innerText->renderer()->lineHeight(true, true), but
RenderFlow::lineHeight() returns s->font().lineSpacing(), which is off by 1.
For fast/forms/textfield-outline.html, it comes down to
RenderTextControlSingleLine::preferredContentWidth() calling
style()->font().primaryFont()->maxCharWidth() which returns a value that's off
by 1.
Review URL: http://codereview.chromium.org/18693
------------------------------------------------------------------------